Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tinkering princess ai [wip] #5569

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Dec 31, 2024

necessary for this PR to build an artifact

It adds a jar com.jetbrains.intellij.java:java-gui-forms-rt which contains the IntelliJ GUI components, which allows the usage of the IntelliJ GUI Editor, and it kinda is better than what Swing has available.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.31%. Comparing base (899ef61) to head (62fcebf).
Report is 39 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5569      +/-   ##
============================================
- Coverage     10.31%   10.31%   -0.01%     
- Complexity     6128     6131       +3     
============================================
  Files          1038     1038              
  Lines        138806   139020     +214     
  Branches      20551    20585      +34     
============================================
+ Hits          14322    14338      +16     
- Misses       123094   123289     +195     
- Partials       1390     1393       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Scoppio Scoppio self-assigned this Jan 9, 2025
@@ -544,7 +546,7 @@
var botName = player.getName() + "@AI";

Thread.sleep(MekHQ.getMHQOptions().getStartGameBotClientDelay());
var botClient = new Princess(botName, client.getHost(), client.getPort());
var botClient = new Queen(botName, client.getHost(), client.getPort(), TWUtilityAIRepository.getInstance().reloadRepository().getProfiles().get(0));

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable ' botClient' is never read.
miAiEditor
.addActionListener(evt -> {
SwingUtilities.invokeLater(() -> {
MegaMekController controller = new MegaMekController();

Check warning

Code scanning / CodeQL

Expression always evaluates to the same value Warning

Expression always evaluates to the same value.
Comment on lines +158 to +159
MegaMekButton btnOpenAiEditor = new MegaMekButton(resources.getString("btnAiEditor.text"),
UIComponents.MainMenuButton.getComp(), true);

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'MegaMekButton btnOpenAiEditor' is never read.
@@ -258,6 +278,11 @@
startCampaign(file, null);
}

private void showAiEditor() {
MegaMekController controller = new MegaMekController();
controller.aiEditor = new AiProfileEditor(controller);

Check warning

Code scanning / CodeQL

Expression always evaluates to the same value Warning

Expression always evaluates to the same value.
@HammerGS HammerGS added the Draft Work in Progress label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Draft Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants